Josh Newth Reviews My Torus Feature

I wrote a demo feature called Torus and put that on my channel to teach Featurescript. I had the incredible opportunity to get that code reviewed by Josh Newth who used to be a developer at Onshape, and now writes Featurescript for a living at Reframe Systems. 🍩 Check out the Torus code here 🍩 (remember to look at the different branches) https://cad.onshape.com/documents/a43... ⚡️ Custom Features Used ⚡️ Report https://cad.onshape.com/documents/e25... Report demo video    • Conditional reporting and visualization in...   00:00 Josh Newth Torus Code Reveiw 05:08 Global Static Constants 09:23 Reviewing my code a bit 13:27 The Power of Functionalized Code 18:24 Alternate Disambiguation Strategy 25:48 Write code for your future self 30:48 Using functions well 37:58 Reuse your code 45:17 Cleaner() function 48:35 Performance of various approaches 55:16 Manipulator names 59:55 Report, viz, and dbg 01:17:21 Instantiator approach 01:21:14 Wrap up